feat: Add ARM64 support and fix Node.js compatibility issues #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Dockerfile and CI workflows to support multi-platform builds (AMD64 and ARM64) while resolving npm dependency compatibility issues. Changes: - Updated Node.js from 16.3.0 to latest 16.x (16.20.2) - Changed runtime stage from bare Alpine to node:16-alpine base image - Added multi-platform build support to all GitHub Actions workflows - Removed redundant nodejs installation in runtime stage Technical Details: The original Dockerfile used Node.js 16.3.0 in the builder stage but installed an older Node.js version from Alpine 3.13 packages in the runtime stage. This caused compatibility issues with newer npm dependencies that require modern JavaScript features: - Object.hasOwn() (added in Node.js 16.9.0) - Logical OR assignment operator ||= (ES2021, Node.js 15.0.0+) Newer versions of winston and its transitive dependencies (@dabh/diagnostics, @so-ric/colorspace) now use these features, causing runtime failures on older Node.js versions. Testing: - Built Docker image on ARM64 architecture (Apple Silicon) - Verified image architecture: arm64 - Successfully ran container and confirmed application startup - Application entered setup mode as expected (no config provided) - No JavaScript syntax errors encountered CI/CD Changes: All three workflow files updated to build multi-platform images: - docker-master.yml (master branch) - docker-preview.yml (preview branch) - docker.yml (dev branch) Added QEMU and Docker Buildx setup to enable cross-platform builds. Images will now be available for both linux/amd64 and linux/arm64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Dockerfile and CI workflows to support multi-platform builds (AMD64 and ARM64) while resolving npm dependency compatibility issues.
Changes
Technical Details
The original Dockerfile used Node.js 16.3.0 in the builder stage but installed an older Node.js version from Alpine 3.13 packages in the runtime stage. This caused compatibility issues with newer npm dependencies that require modern JavaScript features:
Newer versions of winston and its transitive dependencies (@dabh/diagnostics, @so-ric/colorspace) now use these features, causing runtime failures on older Node.js versions.
Testing
CI/CD Changes
All three workflow files updated to build multi-platform images:
Added QEMU and Docker Buildx setup to enable cross-platform builds. Images will now be available for both linux/amd64 and linux/arm64.