Skip to content

Conversation

@petrsvihlik
Copy link
Owner

Fixes #26

@petrsvihlik petrsvihlik temporarily deployed to Integrate Pull Request September 7, 2025 22:24 — with GitHub Actions Inactive
@qltysh
Copy link

qltysh bot commented Sep 7, 2025

❌ 2 blocking issues (2 total)

Tool Category Rule Count
qlty Structure High total complexity (count = 89) 1
qlty Duplication Found 15 lines of similar code in 2 locations (mass = 101) 1

@petrsvihlik petrsvihlik temporarily deployed to Integrate Pull Request September 7, 2025 22:31 — with GitHub Actions Inactive
@petrsvihlik petrsvihlik temporarily deployed to Integrate Pull Request September 7, 2025 22:33 — with GitHub Actions Inactive
@qltysh
Copy link

qltysh bot commented Sep 7, 2025

Diff Coverage: The code coverage on the diff in this pull request is 6.9%.

Total Coverage: This PR will decrease coverage by 10.2%.

File Coverage Changes
Path File Coverage Δ Indirect
src/WopiHost.AzureStorageProvider/AzureBlobWriteStream.cs 0.0
src/WopiHost.AzureStorageProvider/AzureFileIds.cs 61.5
src/WopiHost.AzureStorageProvider/WopiAzureFile.cs 0.0
src/WopiHost.AzureStorageProvider/WopiAzureFolder.cs 0.0
src/WopiHost.AzureStorageProvider/WopiAzureSecurityHandler.cs 0.0
src/WopiHost.AzureStorageProvider/WopiAzureStorageProvider.cs 0.0
src/WopiHost.AzureStorageProvider/WopiAzureStorageProviderOptions.cs 100.0
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@codecov
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

❌ Patch coverage is 6.93069% with 658 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.93%. Comparing base (2e480e1) to head (e90c665).

Files with missing lines Patch % Lines
...t.AzureStorageProvider/WopiAzureStorageProvider.cs 0.00% 388 Missing ⚠️
...t.AzureStorageProvider/WopiAzureSecurityHandler.cs 0.00% 118 Missing ⚠️
src/WopiHost.AzureStorageProvider/WopiAzureFile.cs 0.00% 64 Missing ⚠️
...iHost.AzureStorageProvider/AzureBlobWriteStream.cs 0.00% 53 Missing ⚠️
src/WopiHost.AzureStorageProvider/AzureFileIds.cs 61.53% 25 Missing ⚠️
...c/WopiHost.AzureStorageProvider/WopiAzureFolder.cs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   44.52%   34.93%   -9.60%     
==========================================
  Files          64       71       +7     
  Lines        2064     2771     +707     
  Branches      280      397     +117     
==========================================
+ Hits          919      968      +49     
- Misses       1081     1739     +658     
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petrsvihlik petrsvihlik deployed to Integrate Pull Request September 7, 2025 22:38 — with GitHub Actions Active
Comment on lines +254 to +267
public async Task<T?> CreateWopiChildResource<T>(
string? containerId,
string name,
CancellationToken cancellationToken = default)
where T : class, IWopiResource
{
return typeof(T) switch
{
{ } wopiFileType when typeof(IWopiFile).IsAssignableFrom(wopiFileType) =>
await CreateWopiFile(containerId ?? RootContainerPointer.Identifier, name, cancellationToken) as T,
{ } wopiFolderType when typeof(IWopiFolder).IsAssignableFrom(wopiFolderType) =>
await CreateWopiChildContainer(containerId ?? RootContainerPointer.Identifier, name, cancellationToken) as T,
_ => throw new NotSupportedException("Unsupported resource type.")
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 15 lines of similar code in 2 locations (mass = 101) [qlty:similar-code]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create an auxiliary file provider for azure storage

2 participants