Conversation
…ure-branch Add verification harness for neuroplasticity gold corpus
…with-fixes Add index directory support to multi-agent RAG tooling
…tion-check Fix GPU dependency detection in CI
…nd-improve-cli Fix multi-agent invocation in verification harness
fix(lc_ask): require key-derived faiss selection
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| try: | ||
| if pdf_dir.exists(): | ||
| shutil.rmtree(pdf_dir) | ||
| prepare_pdf_corpus(corpus_dir, pdf_dir) | ||
| except FileNotFoundError as exc: | ||
| raise SystemExit(str(exc)) from exc |
There was a problem hiding this comment.
[P1] Avoid forcing markdown-to-PDF conversion
The verification harness now always calls prepare_pdf_corpus(corpus_dir, pdf_dir) before invoking the builder. prepare_pdf_corpus only accepts .md files and raises FileNotFoundError when the directory contains anything else. Previously, the harness passed the --corpus directory directly to lc_build_index.py, so users could point it at a folder of PDFs (which is exactly what the builder expects). With this change, running the harness against an existing PDF corpus immediately fails with “No markdown files found to convert into PDFs” even though the builder could have processed the PDFs directly. Consider performing this conversion only when markdown files are detected or behind a flag so that existing PDF-based workflows keep working.
Useful? React with 👍 / 👎.
* Dev (#206) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection * Dev (#207) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection
* Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection * mege (#208) * Dev (#206) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection * Dev (#207) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection
1 participant
No description provided.