Conversation
* Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection * mege (#208) * Dev (#206) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection * Dev (#207) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| for cand in (repacked_dir, base_dir): | ||
| if (cand / "index.faiss").exists(): | ||
| faiss_dir = cand | ||
| break | ||
|
|
||
| if args.index_path: | ||
| if args.index_path: | ||
| faiss_dir = Path(args.index_path).expanduser() | ||
| if not faiss_dir.exists(): | ||
| raise SystemExit(f"[lc_ask] FAISS dir not found: {faiss_dir}") |
There was a problem hiding this comment.
[P0] Fix mis-indented if args.index_path block
The newly merged block under main() lost its indentation: the line beginning if args.index_path: is indented with three spaces instead of matching the four-space level of the surrounding code. Python raises IndentationError: unindent does not match any outer indentation level when importing or running this module (python -m py_compile src/langchain/lc_ask.py fails on this line), so the CLI can no longer execute at all. Align the if block with the rest of the function.
Useful? React with 👍 / 👎.
| assert command[:2] == [sys.executable, str(builder)] | ||
|
|
||
| assert command[0] == sys.executable | ||
| assert command[1:3] == ["-m", "src.langchain.lc_build_index"] |
There was a problem hiding this comment.
[P1] Remove impossible assertion in builder command test
The new test now asserts command[:2] == [sys.executable, str(builder)] immediately before asserting command[1:3] == ['-m', 'src.langchain.lc_build_index']. build_builder_command uses script_base_command, so command[:2] will always be [sys.executable, '-m'], never [sys.executable, path/to/lc_build_index.py]. This assertion will fail every run and contradicts the following check. The test should either expect the -m invocation or the function should be changed; as written it is incorrect.
Useful? React with 👍 / 👎.
1 participant
No description provided.