Skip to content

Dev#209

Merged
pfahlr merged 12 commits into
mainfrom
dev
Sep 24, 2025
Merged

Dev#209
pfahlr merged 12 commits into
mainfrom
dev

Conversation

@pfahlr

@pfahlr pfahlr commented Sep 24, 2025

Copy link
Copy Markdown
Owner

No description provided.

…ure-branch

Add verification harness for neuroplasticity gold corpus
…with-fixes

Add index directory support to multi-agent RAG tooling
…tion-check

Fix GPU dependency detection in CI
…nd-improve-cli

Fix multi-agent invocation in verification harness
fix(lc_ask): require key-derived faiss selection
* Dev (#206)

* Fix verification harness index build commands

* Add index directory support to multi-agent RAG tooling

* Fix GPU dependency detection in CI

* Fix multi-agent invocation in verification harness

* fix(lc_ask): require key-derived faiss selection

* Dev (#207)

* Fix verification harness index build commands

* Add index directory support to multi-agent RAG tooling

* Fix GPU dependency detection in CI

* Fix multi-agent invocation in verification harness

* fix(lc_ask): require key-derived faiss selection
@pfahlr pfahlr merged commit 8a0b1e8 into main Sep 24, 2025
0 of 2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment thread src/langchain/lc_ask.py
Comment on lines +357 to 360
if args.index_path:
faiss_dir = Path(args.index_path).expanduser()
if not faiss_dir.exists():
raise SystemExit(f"[lc_ask] FAISS dir not found: {faiss_dir}")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P0] Repair mis-indented lc_ask branch causing SyntaxError

The refactor around the index resolution block left if args.index_path: indented with three spaces while the surrounding function uses four. Python treats this as an inconsistent unindent and refuses to compile the module (IndentationError: unindent does not match any outer indentation level). Importing or running lc_ask.py now crashes before any logic executes, so the CLI is broken until the block is properly re-indented.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant