Skip to content

Modify the toolbar#162

Open
SEVA77 wants to merge 7 commits into
pfalstad:masterfrom
SEVA77:modify-the-toolbar
Open

Modify the toolbar#162
SEVA77 wants to merge 7 commits into
pfalstad:masterfrom
SEVA77:modify-the-toolbar

Conversation

@SEVA77
Copy link
Copy Markdown

@SEVA77 SEVA77 commented May 3, 2025

I tried to make this as comfortable as possible but perhaps you may not like some of this changes. At first, I just wanted to add separators but I did not stop at this. In general:

  • Added separators to the toolbar
  • Added file options to the toolbar (new, open file, save, save as)
  • Added symbol "+" to "Save As" icon for the visual differences between "save" and "save as"
  • Added "Centre Circuit" option to the toolbar
  • Moved info about mouse mode from the toolbar to the work area (graphics)
  • Added chechbox in options for show/hide info about mouse mode

Upd: I hid the "Save" option on toolbar for Electron because need additional conditions for it. It should not be available always.

Screenshot:
Снимок экрана_2025-05-03_21-00-35

esaruoho added a commit to esaruoho/circuitjs1 that referenced this pull request Mar 1, 2026
…s, centre circuit, and show mode toggle

Cherry-picks SEVA77's PR pfalstad#162 changes onto current master with conflict resolution:
- Add file operation buttons (New, Open, Save As) to toolbar
- Add visual separators between toolbar sections
- Add Centre Circuit button to toolbar
- Add "Show Mode" checkbox (Options menu) to toggle mode display location
- When Show Mode is ON: mode info shown as canvas overlay (PR pfalstad#162 approach)
- When Show Mode is OFF: mode info shown in toolbar label (master approach)
- Both approaches coexist; master's enhanced setModeLabel with "Drag Mouse" state preserved

Co-Authored-By: SEVA77 <CEBA1996@outlook.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@esaruoho
Copy link
Copy Markdown

esaruoho commented Mar 1, 2026

I've rebased your toolbar changes onto v3-dev in #232 — separators, file ops, centre button, and mode display all carried over. Once #232 lands, this one can be closed. Thanks for the toolbar work!

esaruoho added a commit to esaruoho/circuitjs1 that referenced this pull request Mar 2, 2026
…ad#212)

Port SEVA77 toolbar enhancements to v3-dev architecture:

Toolbar.java:
- Add toolbar separators between button groups for visual clarity
- Add file operation buttons (New, Open, Save As) to toolbar
- Add + symbol to Save As icon for visual distinction from Save
- Add Centre Circuit button to toolbar
- Handle Electron vs browser Save As command differences

Menus.java:
- Add Show Mode checkbox to Options menu (persisted to storage)

UIManager.java:
- Draw mouse mode info on canvas when Show Mode is enabled
- Shift developer mode text down to avoid overlap with mode display

Original PR by SEVA77, remapped to v3-dev split architecture.

Co-Authored-By: SEVA77 <CEBA1996@outlook.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
esaruoho added a commit to esaruoho/circuitjs1 that referenced this pull request Apr 15, 2026
…ad#212)

Port SEVA77 toolbar enhancements to v3-dev architecture:

Toolbar.java:
- Add toolbar separators between button groups for visual clarity
- Add file operation buttons (New, Open, Save As) to toolbar
- Add + symbol to Save As icon for visual distinction from Save
- Add Centre Circuit button to toolbar
- Handle Electron vs browser Save As command differences

Menus.java:
- Add Show Mode checkbox to Options menu (persisted to storage)

UIManager.java:
- Draw mouse mode info on canvas when Show Mode is enabled
- Shift developer mode text down to avoid overlap with mode display

Original PR by SEVA77, remapped to v3-dev split architecture.

Co-Authored-By: SEVA77 <CEBA1996@outlook.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
esaruoho added a commit to esaruoho/circuitjs1 that referenced this pull request Apr 15, 2026
…ad#212)

Port SEVA77 toolbar enhancements to v3-dev architecture:

Toolbar.java:
- Add toolbar separators between button groups for visual clarity
- Add file operation buttons (New, Open, Save As) to toolbar
- Add + symbol to Save As icon for visual distinction from Save
- Add Centre Circuit button to toolbar
- Handle Electron vs browser Save As command differences

Menus.java:
- Add Show Mode checkbox to Options menu (persisted to storage)

UIManager.java:
- Draw mouse mode info on canvas when Show Mode is enabled
- Shift developer mode text down to avoid overlap with mode display

Original PR by SEVA77, remapped to v3-dev split architecture.

Co-Authored-By: SEVA77 <CEBA1996@outlook.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants