Configurable simulation temperature for diodes and transistors (#147)#243
Open
esaruoho wants to merge 1 commit intopfalstad:devfrom
Open
Configurable simulation temperature for diodes and transistors (#147)#243esaruoho wants to merge 1 commit intopfalstad:devfrom
esaruoho wants to merge 1 commit intopfalstad:devfrom
Conversation
This was referenced Mar 2, 2026
4434f25 to
4a5296c
Compare
4a5296c to
e52ddf3
Compare
Adds a user-settable simulation temperature (in celsius) to the Options dialog, with updates to Diode, DiodeModel, and TransistorElm so the thermal voltage (kT/q) they use is derived from CirSim.temperature rather than a hardcoded 300.15K. Closes pfalstad#147. The field is placed just before the Auto-Adjust Timestep checkbox so it is visible regardless of adjustTimeStep state. CirSim.vt is the shared thermal voltage constant; TransistorElm uses CirSim.vt throughout its junction-cap/transit-time companion-model math. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e52ddf3 to
6462b94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased onto
v3-dev(replaces #225 which targeted master).temperatureandvt(thermal voltage) fields on CirSimsetTemperature()recalculates vt = kT/q and refreshes all diode modelsCirSim.vtinstead of hardcoded constantFixes #147.
Test plan
🤖 Generated with Claude Code