Add gmin stepping to VCCS/CCCS for convergence aid#255
Open
esaruoho wants to merge 1 commit intopfalstad:devfrom
Open
Add gmin stepping to VCCS/CCCS for convergence aid#255esaruoho wants to merge 1 commit intopfalstad:devfrom
esaruoho wants to merge 1 commit intopfalstad:devfrom
Conversation
When Newton-Raphson subiterations exceed 100, add a gradually increasing parallel conductance (gmin) across the controlled source output nodes. This follows the same pattern used by Diode.java and TransistorElm.java. Without this, circuits with controlled sources in positive feedback loops (e.g., optocoupler Schmitt triggers) can fail to converge because the solver oscillates between two states with no damping mechanism. The gmin conductance provides damping that helps the solver find a stable solution. Uses a slower ramp rate (subIterations/3000) than transistors (subIters/300) to minimize impact on circuits that converge normally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
342887d to
4af394c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes #172
🤖 Generated with Claude Code