Skip to content

Hindsight Experience Replay Buffer #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Hindsight Experience Replay Buffer #84

wants to merge 48 commits into from

Conversation

@prabhatnagarajan
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan commented Oct 28, 2020 •
edited
Loading

Depends on #80.
Resolves #6.

Results:

her_bit_flip_dqn

@prabhatnagarajan
Copy link
Contributor Author

prabhatnagarajan commented Oct 28, 2020

/test

@pfn-ci-bot
Copy link

pfn-ci-bot commented Oct 28, 2020

Successfully created a job for commit 71809a5:

@prabhatnagarajan
Copy link
Contributor Author

prabhatnagarajan commented Oct 29, 2020

/test

@pfn-ci-bot
Copy link

pfn-ci-bot commented Oct 29, 2020

Successfully created a job for commit 9721d1a:

@prabhatnagarajan
Copy link
Contributor Author

prabhatnagarajan commented Oct 29, 2020

/test

@pfn-ci-bot
Copy link

pfn-ci-bot commented Oct 29, 2020

Successfully created a job for commit 8643e0d:

justindujardin
justindujardin reviewed Oct 29, 2020
View reviewed changes
@pfn-ci-bot
Copy link

pfn-ci-bot commented Nov 5, 2020

Successfully created a job for commit 573c7a2:

@prabhatnagarajan
Copy link
Contributor Author

prabhatnagarajan commented Nov 6, 2020

/test

@pfn-ci-bot
Copy link

pfn-ci-bot commented Nov 6, 2020

Successfully created a job for commit ed4ae2e:

@prabhatnagarajan
Copy link
Contributor Author

prabhatnagarajan commented Mar 30, 2021

Current results
PickAndPlace
Push
Slide

@prabhatnagarajan
Copy link
Contributor Author

prabhatnagarajan commented Mar 30, 2021

/test

@pfn-ci-bot
Copy link

pfn-ci-bot commented Mar 30, 2021

Successfully created a job for commit ef230a4:

@ummavi
Copy link
Member

ummavi commented May 20, 2021

/test

@pfn-ci-bot
Copy link

pfn-ci-bot commented May 20, 2021

Successfully created a job for commit 35f085c:

prabhatnagarajan
prabhatnagarajan commented Jun 15, 2023
View reviewed changes
examples/her/train_dqn_bit_flip.py
success = (
self.observation["desired_goal"] == self.observation["achieved_goal"]
).all()
return (self.steps >= self.n) or success, success
Copy link
Contributor Author

@prabhatnagarajan prabhatnagarajan Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should use the wrapper ContinuingTimeLimit actually. Exceeding the number of timesteps should not be a terminal signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ummavi ummavi Awaiting requested review from ummavi

1 more reviewer

@justindujardin justindujardin justindujardin left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hindsight Experience Replay

5 participants

@prabhatnagarajan @pfn-ci-bot @muupan @ummavi @justindujardin