Skip to content

feat: allow username + password auth #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: REL_16_STABLE
Choose a base branch
from

Conversation

TheGreatRefrigerator
Copy link

with redis ACL settings it's possible to setup auth per user. The wrapper could previously just pass a password to the redis cli AUTH command. The option to pass a username in addition to the password was added. It will be resolved to redis cli:
AUTH <username> <password>

There is also a change on the master branch if it should rather go to master

with redis ACL settings it's possible to setup auth per user.
The wrapper could previously just pass a password to the redis cli AUTH command.
The option to pass a username in addition to the password was added.
It will be resolved to redis cli:
`AUTH <username> <password>`

Co-authored-by: joker234 <[email protected]>
@mkgrgis
Copy link

mkgrgis commented Apr 5, 2025

@TheGreatRefrigerator , what about tests? In C contribution usual 10-15% of time is coding, 75-90% is test creating and some other time is discussing about implementation.

@TheGreatRefrigerator
Copy link
Author

Hi @mkgrgis,

i didn't really get this to run on my machine 😓 and am not too familiar with programming in C,
so i can't create a "full" PR.

We've managed to run this on our system and get the connection to work, which failed before without this integration.

Feel free to use this and add tests or discard the PR as you like.

@mkgrgis
Copy link

mkgrgis commented Apr 7, 2025

Hi @mkgrgis,

i didn't really get this to run on my machine 😓 and am not too familiar with programming in C, so i can't create a "full" PR.

This is normal, @TheGreatRefrigerator ! You don't need write any tests on C. Please look at my simple PR to similar SQLite FDW pgspider/sqlite_fdw@90dad0a This commit and PR pgspider/sqlite_fdw#76 also contains small C changes. The main is you must ensure in SQL tests your contribution will not destroyed. In my case all this test guarantees my contribution and expected behaviour will dot destroyed.

We've managed to run this on our system and get the connection to work, which failed before without this integration.

My initial problems was similar. This is normal 1st step.

I think you should also manipulate with https://github.com/pg-redis-fdw/redis_fdw/blob/REL_16_STABLE/test/sql/redis_fdw.sql and https://github.com/pg-redis-fdw/redis_fdw/blob/REL_16_STABLE/test/expected/redis_fdw.out

Feel free to use this and add tests or discard the PR as you like.

Unfortunately, I am not committer of this repository.

P. s. If you are interesting about C integration between Redis and PostGIS, I can help with reviews and consult about API. You can see proofs of my skills on pgspider/sqlite_fdw#96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants