Skip to content

Boost version PoC: planarFaces - #625

Open
sakirr05 wants to merge 2 commits into
pgRouting:sakir-2026-face-extractionfrom
sakirr05:boost-poc-1.80
Open

Boost version PoC: planarFaces#625
sakirr05 wants to merge 2 commits into
pgRouting:sakir-2026-face-extractionfrom
sakirr05:boost-poc-1.80

Conversation

@sakirr05

@sakirr05 sakirr05 commented Aug 15, 2026

Copy link
Copy Markdown

Rebuilt this PoC on top of sakir-2026-face-extraction. The earlier version was
branched from main and contained none of my algorithm code, so the all-pass
result said nothing about planarFaces. Also corrected the earlier body, which
claimed 1.79 failed when CI showed it passing.

  • 1.55 expected to fail (below BOOST_MINIMUM_VERSION 1.56.0 in CMakeLists.txt)
  • 1.56 expected to pass (critical version)
  • 1.57 expected to pass

pgr_planarFaces uses graph_traits, property_map, boyer_myrvold_planar_test and
planar_face_traversal, all present in boost since 1.40, so the algorithm does
not raise pgRouting's declared 1.56 minimum.

Download switched from sourceforge to https://archives.boost.io.

Result:

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d8b45f6-2f56-4916-bc7b-32e8b1a7a50c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sakirr05 sakirr05 added this to the 2026 Second coding period milestone Aug 15, 2026
@sakirr05
sakirr05 changed the base branch from main to develop August 15, 2026 05:08
@sakirr05
sakirr05 changed the base branch from develop to sakir-2026-face-extraction August 17, 2026 22:03
@sakirr05 sakirr05 changed the title Boost poc 1.80 Boost version PoC: planarFaces Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant