Boost version PoC: planarFaces - #625
Open
sakirr05 wants to merge 2 commits into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sakirr05
force-pushed
the
boost-poc-1.80
branch
from
August 17, 2026 21:55
04d25c8 to
073f527
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilt this PoC on top of sakir-2026-face-extraction. The earlier version was
branched from main and contained none of my algorithm code, so the all-pass
result said nothing about planarFaces. Also corrected the earlier body, which
claimed 1.79 failed when CI showed it passing.
pgr_planarFaces uses graph_traits, property_map, boyer_myrvold_planar_test and
planar_face_traversal, all present in boost since 1.40, so the algorithm does
not raise pgRouting's declared 1.56 minimum.
Download switched from sourceforge to https://archives.boost.io.
Result: