-
-
Notifications
You must be signed in to change notification settings - Fork 376
Test topological sort #2877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Test topological sort #2877
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WHERE id = 2; | ||
|
||
RETURN QUERY | ||
SELECT set_eq('q3', $$VALUES (2, 6, 6, -1, -1)$$, 'q3: Graph with one vertex'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is irrelevant, you are testing what you are selecting in the query above.
Thanks we appreciate the effort As the PR is focused on unit tests:
Remove the irrelevant tests for this PR to be merged. The noise from the locale directory will disappear (hopefully) |
a8182c1
to
c723816
Compare
c723816
to
c721e72
Compare
@cvvergara I have removed the irrelevant tests |
Changes proposed in this pull request:
pgr_topologicalSort
@pgRouting/admins