Skip to content

clang-tidy: enable cppcoreguidelines-avoid-magic-numbers#3096

Open
bakshi536 wants to merge 1 commit intopgRouting:developfrom
bakshi536:tavgun-clang-tidy
Open

clang-tidy: enable cppcoreguidelines-avoid-magic-numbers#3096
bakshi536 wants to merge 1 commit intopgRouting:developfrom
bakshi536:tavgun-clang-tidy

Conversation

@bakshi536
Copy link

@bakshi536 bakshi536 commented Mar 14, 2026

Fixes # .

Changes proposed in this pull request:

@pgRouting/admins

Summary by CodeRabbit

Release Notes

This release contains only internal tooling configuration updates with no user-facing changes. Code quality checks have been enhanced to better enforce development standards.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2442068a-3782-44fe-af26-c105e6b26db9

📥 Commits

Reviewing files that changed from the base of the PR and between e06c177 and 748db50.

📒 Files selected for processing (1)
  • .clang-tidy

Walkthrough

The clang-tidy configuration file is updated to enable the cppcoreguidelines-avoid-magic-numbers check by removing its negation prefix. This activates enforcement of the magic number avoidance rule in the active check set, while all other configuration settings remain unchanged.

Changes

Cohort / File(s) Summary
Configuration
.clang-tidy
Enabled cppcoreguidelines-avoid-magic-numbers check by removing the negation prefix from the rule.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

Enhancement, C/C++

Suggested reviewers

  • cvvergara
  • robe2

Poem

🐰 A magic number audit now takes flight,
No mystic digits hiding from our sight!
With clang-tidy's gaze so sharp and keen,
The cleanest code you've ever seen! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: enabling a specific clang-tidy rule (cppcoreguidelines-avoid-magic-numbers).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant