Skip to content

Improve warning when collector is paused by duplicate process #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

seanlinsley
Copy link
Member

The collector pause warning may have made sense to us internally, but it doesn't help users identify the issue on their own. This PR rewords it to be very clear about how to resolve the issue, though it removes the "processing disabled" part to avoid making the message too long.

In passing, this PR also updates the test run summary to use simpler wording.

@seanlinsley seanlinsley requested a review from a team April 4, 2025 18:25
Copy link
Contributor

@msakrejda msakrejda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for clarifying this. We don't use periods elsewhere in similar messages, so I proposed a rewording to just use a colon. A semicolon or a different rewording could also work.

@seanlinsley seanlinsley merged commit 303c934 into main Apr 9, 2025
3 checks passed
@seanlinsley seanlinsley deleted the duplicate-collector-message branch April 9, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants