Add option to automatically try all parse modes#228
Open
seanlinsley wants to merge 1 commit into15-latestfrom
Open
Add option to automatically try all parse modes#228seanlinsley wants to merge 1 commit into15-latestfrom
seanlinsley wants to merge 1 commit into15-latestfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
PG_QUERY_PARSE_ALLparse mode to automatically try every parse mode, which is helpful if you're parsing a query and don't know ahead of time which parse mode is valid for the query.Additionally, this adds
pg_query_normalize_optswhich was missed by #216.Note that the parse tree and fingerprints are different for some queries because multiple parse modes are able to parse the query. The
NEW.nameandNEW.author.first_nameparse trees are actually incorrect so we may need to change the order in which the parse modes are tried.Todo:
Per 1/9 meeting: