New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) Add `pg_query_parse_summary()` and supporting code #274

Draft

duckinator wants to merge 29 commits into pganalyze:17-latest from duckinator:summary

duckinator commented Feb 27, 2025 •

edited

Loading

No description provided.

duckinator commented

View reviewed changes

scripts/generate_protobuf_and_funcs.rb Outdated Show resolved Hide resolved

scripts/generate_protobuf_and_funcs.rb Outdated Show resolved Hide resolved

scripts/generate_protobuf_and_funcs.rb Outdated Show resolved Hide resolved

scripts/generate_protobuf_and_funcs.rb Outdated Show resolved Hide resolved

seanlinsley reviewed

View reviewed changes

pg_query.h Show resolved Hide resolved

lfittl reviewed

View reviewed changes

protobuf/pg_query.proto Outdated

Comment on lines 4122 to 4123

		message Table {
		string table = 1;

Member

lfittl Feb 28, 2025

As discussed, probably best to follow the Ruby structure here, which has a few more fields:

https://github.com/pganalyze/pg_query/blob/main/lib/pg_query/parse.rb#L319

lfittl reviewed

View reviewed changes

protobuf/pg_query.proto Show resolved Hide resolved

lfittl reviewed

View reviewed changes

protobuf/pg_query.proto Show resolved Hide resolved

lfittl reviewed

View reviewed changes

protobuf/pg_query.proto Outdated Show resolved Hide resolved

lfittl reviewed

View reviewed changes

protobuf/pg_query.proto Outdated Show resolved Hide resolved

lfittl reviewed

View reviewed changes

protobuf/pg_query.proto Show resolved Hide resolved

duckinator force-pushed the summary branch 3 times, most recently from da68209 to 9fac504 Compare

March 4, 2025 17:46

duckinator added 19 commits

April 3, 2025 14:40


          Add first-pass at SummaryResult protobuf info.

dc01b31


          Add signature for PgQuerySummaryParseResult + pg_query_parse_summary().

5ce124b


          Improve Protobuf definition for SummaryResult based on initial review.

97a4495


          Regenerate protobuf/

dcf27fe


          Update scripts/generate_protobuf_and_funcs.rb based on review feedback.

ab960e3


          Regenerate protobuf/pg_query.proto.

9cf0260


          Regenerate protobuf/pg_query.pb-c.{c,h}


          Add "plumbing" for pg_query_parse_summary().

3d1bc88


          [parse summary] Add comments, re-order parameters, un-comment default…

19d2e74

… return values, rename need_truncate -> should_truncate.


          Add (WIP) pg_query_parse_summary tests.

d58ef6c


          Fix error handling in pg_query_parse_summary

5511b9c


          [parse_summary] implement basic code for tree walking

f51373e


          [parse_summary] disable second test, make first test more useful


          [parse_summary] handle more of tree walking

85576ff


          [parse_summary_walk_impl] add most of SelectStmt branch; one part is …

da983a6

…incomplete with comments explaining what needs figured out


          [parse_summary] track clause type information (select vs DDL)

ba8ee79


          [parse_summary] Beginning of work actually returning protobuf stuff.

aa01e52


          Add pg_query_cte_names_include()

160b0a0


          use pfree() instead of free()

2e9fc93

duckinator added 10 commits

April 3, 2025 14:40


          [parse_summary] functions field should be repeated (equivalent to a V…

d75b350

…ec).


          [parse_summary] I *think* it's generating valid protobuf? I guess I n…

a28d085

…eed to test that now.


          [parse_summary] improve comments

4f337f2


          [summary] Use malloc()/free() instead of palloc()/pfree() for result.…

e007937

…summary.data.


          [parse_summary] It can actually get through pg_query_parse_summary_to…

6b19850

…_protobuf() without segfaulting


          [parse_summary] Avoid referencing relname if it's NULL.

4a0397d


          [parse_summary] Handle truncated_query being NULL.

525fa4f


          [parse_summary] Use temporary variables to improve readability.

7e73bf8


          [parse_summary] Use List for most things in the Summary struct.

38f4925


          [parse_summary] Rename summary_result to sr so the code is less noisy.

70af067

duckinator force-pushed the summary branch from a103089 to 70af067 Compare

April 3, 2025 18:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet