Add functionality to build Windows shared lib dll#296
Open
mysticmind wants to merge 7 commits intopganalyze:17-latestfrom
Open
Add functionality to build Windows shared lib dll#296mysticmind wants to merge 7 commits intopganalyze:17-latestfrom
mysticmind wants to merge 7 commits intopganalyze:17-latestfrom
Conversation
Author
|
@lfittl Did you get a chance to take a look at this PR? |
Member
Not yet! I saw this come in, but had some competing priorities. This is on my list to get to however, thanks for your patience. |
Author
|
@lfittl Hey Lukas, just checking to see when you could review and merge this PR. If there is anything bothering you, please let me know, I am happy to fix/address it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_shared targetinMakefile.mvccpg_query.defto export the required functions. Add functionality to create the file dynamically by extracting the info frompg_query.husing a Powershell script. It is wired viacreate_deftarget inMakefile.mvccPS: I am in the process of building a .NET based lib for
libpg_queryand wanted cross-platform shared libs of libpg_query targeting *nix, OSX and Windows. Noticed the DLL build for Windows was missing hence this PR.