Deparser: Fix handling of constraint key named "value" in ALTER TABLE#329
Merged
Deparser: Fix handling of constraint key named "value" in ALTER TABLE#329
Conversation
This was being ignored in all cases, but it should only be ignored if the Constraint object is originating in an ALTER DOMAIN statement. pganalyze/pg_query_go#148
seanlinsley
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was being ignored in all cases, but it should only be ignored if the Constraint object is originating in an ALTER DOMAIN statement.
Fixes pganalyze/pg_query_go#148
Note on AI tool use: Claude Code was used to write out the code once the issue was identified. I've manually verified that the Postgres "gram.y" only adds this dummy constraint key for ALTER DOMAIN (interestingly, not for CREATE DOMAIN).