-
Notifications
You must be signed in to change notification settings - Fork 17
(WIP) Add benchmarks comparing performance of parse functions #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
duckinator
wants to merge
2
commits into
pganalyze:main
Choose a base branch
from
duckinator:benchmarks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
use std::ffi::CString; | ||
|
||
pub fn build_query(table_references: i32) -> String { | ||
let mut query = "SELECT * FROM t".to_string(); | ||
for i in 0..table_references { | ||
query = format!("{query} JOIN t{i} ON t.id = t{i}.t_id AND t{i}.k IN (1, 2, 3, 4) AND t{i}.f IN (SELECT o FROM p WHERE q = 'foo')"); | ||
} | ||
query | ||
} | ||
|
||
pub fn seed() -> String { | ||
build_query(100) | ||
} | ||
|
||
pub fn c_seed() -> CString { | ||
CString::new(seed()).unwrap() | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
mod helpers; | ||
use helpers::*; | ||
|
||
use std::ffi::c_char; | ||
use brunch::Bench; | ||
use pg_query; | ||
use pg_query::bindings::{pg_query_parse, pg_query_parse_protobuf}; | ||
|
||
|
||
// pub fn pg_query_parse_protobuf(input: *const ::std::os::raw::c_char) -> PgQueryProtobufParseResult; | ||
// pub fn pg_query_parse_protobuf_opts(input: *const ::std::os::raw::c_char, parser_options: ::std::os::raw::c_int) -> PgQueryProtobufParseResult; | ||
|
||
// pub fn pg_query_parse(input: *const ::std::os::raw::c_char) -> PgQueryParseResult; | ||
// pub fn pg_query_parse_opts(input: *const ::std::os::raw::c_char, parser_options: ::std::os::raw::c_int) -> PgQueryParseResult; | ||
|
||
// pg_query_raw_parse ? | ||
|
||
brunch::benches!( | ||
Bench::new("pg_query_parse") | ||
.run_seeded_with(c_seed, |query| { | ||
unsafe { pg_query_parse(query.as_ptr() as *const c_char) } | ||
//let result = pg_query::parse(&query); | ||
//assert!(result.is_ok()); | ||
}), | ||
); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
mod helpers; | ||
use helpers::*; | ||
|
||
use std::ffi::c_char; | ||
use brunch::Bench; | ||
use pg_query; | ||
use pg_query::bindings::{pg_query_parse, pg_query_parse_protobuf}; | ||
|
||
|
||
brunch::benches!( | ||
Bench::new("pg_query_parse_protobuf") | ||
.run_seeded_with(c_seed, |query| { | ||
unsafe { pg_query_parse_protobuf(query.as_ptr() as *const c_char) } | ||
}), | ||
); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,7 @@ | |
//! ``` | ||
//! | ||
|
||
mod bindings; | ||
pub mod bindings; | ||
mod error; | ||
mod node_enum; | ||
mod node_mut; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be interesting to include the deserialization in Rust as well, so we can get a sense for where to optimize (if we were to optimize the serialization itself).
For the protobuf parse benchmark we can use the same mechanism the crate currently uses. For JSON we could (just for testing) use the mechanism that pg_parse uses (which shares a common history with this crate, but we since diverged to focus on the Protobuf format).