Skip to content

Prost upgrade followup #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Prost upgrade followup #52

merged 2 commits into from
Apr 2, 2025

Conversation

seanlinsley
Copy link
Member

@seanlinsley seanlinsley commented Apr 2, 2025

Followup to #51, this:

  • Disables the formatter for the generated protobuf file, since cargo build and cargo fmt disagree on how it should be formatted
  • Replaces uses of from_i32 with try_from, since from_i32 has been deprecated:
warning: use of deprecated associated function `protobuf::ObjectType::from_i32`: Use the TryFrom<i32> implementation instead
   --> src/parse_result.rs:135:95
    |
135 |                     if let Some(protobuf::ObjectType::ObjectFunction) = protobuf::ObjectType::from_i32(s.rename_type) {
    |                                                                                               ^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

This ensures that `cargo build` and `cargo fmt` don't repeatedly rewrite the file
@seanlinsley seanlinsley requested a review from a team April 2, 2025 00:34
@seanlinsley seanlinsley merged commit 65a6b5f into main Apr 2, 2025
7 checks passed
@seanlinsley seanlinsley deleted the prost-followup branch April 2, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants