Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macos-latest to CI matrix #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

purcell
Copy link

@purcell purcell commented Apr 1, 2025

This should provide coverage of ARM-based MacOS, e.g. for issues like #327.

@lfittl
Copy link
Member

lfittl commented Apr 1, 2025

This should provide coverage of ARM-based MacOS, e.g. for issues like #327.

Good idea, but looks like that succeeded despite the reported failure on 15.4. I'm assuming that the GH action runners are not updated yet, making this less useful. I'll have to check if there is any other downside to enabling this (I recall macOS runners had lower limits?) but if there are no downsides happy to enable it for extra coverage.

@lfittl
Copy link
Member

lfittl commented Apr 2, 2025

I ended up adding this on the libpg_query side, where I think this matters most: pganalyze/libpg_query@e46bdf8

Unless you think there is a chance there will be macOS and Ruby-specific issues, I'd prefer we don't add more test runs here (since Linux and macOS Ruby builds are sufficiently similar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants