-
Notifications
You must be signed in to change notification settings - Fork 84
fix: go mod vendor #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: go mod vendor #131
Conversation
Thanks for the contribution! - I'm definitely open to making this work, so we can drop the extra effort with vendoring the library.
I don't think that's the right approach, since Postgres major releases will bring different include folders, and so we'd have to update that patch each time. What if instead we came up with a list of all include directories (through bash scripting) and then auto-generated the relevant keep files during the extract source step? We could have each of the nested files use this template:
And then only have the list of imports at the top-level Do you want to adjust the PR to work like that? |
Yeah, that makes sense, I'll update my PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I've confirmed this works as expected and the gokeep files are created correctly. Thank you for fixing this!
Thanks to pganalyze/pg_query_go#131 Note this commit removes many ".proto" files in other modules, but its assumed these are not needed.
Thanks to pganalyze/pg_query_go#131 Note this commit removes many ".proto" files in other modules, but its assumed these are not needed.
Fixes #61
Inspired by:
Changes:
gokeep.go
files to (like.gitkeep
) to force Go tooling to keep non-Go (.c
and.h
) files when vendoring.parser/build_cgo.go
file importing allgokeep
packages.scripts/gokeep.sh
onmake update_source
.