Skip to content

remove redundant copy in ParseToProtobuf#139

Merged
lfittl merged 5 commits intopganalyze:mainfrom
asmyasnikov:main
Jan 28, 2026
Merged

remove redundant copy in ParseToProtobuf#139
lfittl merged 5 commits intopganalyze:mainfrom
asmyasnikov:main

Conversation

@asmyasnikov
Copy link
Contributor

No description provided.

@asmyasnikov asmyasnikov marked this pull request as ready for review August 23, 2025 04:31
fail-fast: false
matrix:
go: ['1.20', '1.21']
go: ['1.14', '1.15', '1.16', '1.17', '1.18', '1.19', '1.20', '1.21']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temponary for check CI on old versions of go (because minimal version of go in go.mod - 1.14)
before merge - need to remove my changes

@lfittl
Copy link
Member

lfittl commented Aug 28, 2025

Thanks for the PR! I think that makes sense, but it appears we'd have to raise the go.mod version to allow using the newer syntax (see https://github.com/pganalyze/pg_query_go/actions/runs/17171245591/job/49052448270?pr=139).

Maybe that's reasonable to do? There isn't a particular need I'm aware of to keep supporting older versions than Go 1.20 (and in fact, any version older than 1.23 is already EOL, so anyone using older versions should have upgraded already).

Also it appears older Go versions fail on Windows in CI, so we can't reasonably test older than 1.20 anyway.

Copy link
Member

@lfittl lfittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some minor revisions to drop old versions - thanks for the contribution!

@lfittl lfittl merged commit b905b5e into pganalyze:main Jan 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments