remove redundant copy in ParseToProtobuf#139
Conversation
.github/workflows/ci.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| go: ['1.20', '1.21'] | ||
| go: ['1.14', '1.15', '1.16', '1.17', '1.18', '1.19', '1.20', '1.21'] |
There was a problem hiding this comment.
temponary for check CI on old versions of go (because minimal version of go in go.mod - 1.14)
before merge - need to remove my changes
|
Thanks for the PR! I think that makes sense, but it appears we'd have to raise the Maybe that's reasonable to do? There isn't a particular need I'm aware of to keep supporting older versions than Go 1.20 (and in fact, any version older than 1.23 is already EOL, so anyone using older versions should have upgraded already). Also it appears older Go versions fail on Windows in CI, so we can't reasonably test older than 1.20 anyway. |
lfittl
left a comment
There was a problem hiding this comment.
I've made some minor revisions to drop old versions - thanks for the contribution!
No description provided.