Skip to content

restore missing binding symbols for pg19 #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eeeebbbbrrrr merged 2 commits into from
Jun 23, 2026
Merged

restore missing binding symbols for pg19 #2335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1497c74
restore missing binding symbols for pg19
eeeebbbbrrrr Jun 23, 2026
3e1ca5c
update-versions.sh now passes the 'cshim' feature so our bindings for…
eeeebbbbrrrr Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pgrx-pg-sys/include/pg19.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@
#include "storage/itemptr.h"
#include "storage/lmgr.h"
#include "storage/lwlock.h"
#include "storage/proc.h"
#include "storage/procarray.h"
#include "storage/relfilelocator.h"
#include "storage/smgr.h"
Expand Down Expand Up @@ -215,7 +216,9 @@
#include "utils/catcache.h"
#include "utils/syscache.h"
#include "utils/tuplestore.h"
#include "utils/tuplesort.h"
#include "utils/typcache.h"
#include "utils/wait_event.h"
#include "utils/rangetypes.h"
#include "utils/rel.h"
#include "utils/varlena.h"
12 changes: 12 additions & 0 deletions pgrx-pg-sys/src/include.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,18 @@ mod internal {
/// We keep the alias so version-portable code can still say `pg_sys::bits8`.
pub type bits8 = u8;

/// PG19 turned `BufferLockMode` into an enum; bindgen emits module-scoped constants.
/// Re-export at the crate root for code written against older pgrx bindings.
pub const BUFFER_LOCK_UNLOCK: u32 = crate::pg19::BufferLockMode::BUFFER_LOCK_UNLOCK;
pub const BUFFER_LOCK_SHARE: u32 = crate::pg19::BufferLockMode::BUFFER_LOCK_SHARE;
pub const BUFFER_LOCK_EXCLUSIVE: u32 = crate::pg19::BufferLockMode::BUFFER_LOCK_EXCLUSIVE;

/// PG19 renamed `PageSetChecksumInplace` to `PageSetChecksum`.
#[inline]
pub unsafe fn PageSetChecksumInplace(page: crate::Page, blkno: crate::BlockNumber) {
crate::pg19::PageSetChecksum(page, blkno);
}

/// # Safety
///
/// This function wraps Postgres' internal `IndexBuildHeapScan` method, and therefore, is
Expand Down
Loading
Loading