Fix bug in calculation of circle location#182
Closed
ktchen14 wants to merge 1 commit intopgeu:masterfrom
Closed
Conversation
Member
|
This has been applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code to render a badge draws a circle at the specified
ylocation + half the radius. From the user's perspective, this means that theyvalue specified in acircleis actually the chord through the circle located halfway between the topmost point and the center.This is really difficult to use. The
yvalue should correspond to either (1) the line tangent to the topmost point of the circle or (2) the horizontal diameter line of the circle.This PR changes the
yvalue to mean (1).