Include feedback URL QR code on the callforpapers page#195
Include feedback URL QR code on the callforpapers page#195ssinger wants to merge 3 commits intopgeu:masterfrom
Conversation
This makes it easy for speakers to include the feedback QR code in their slides
|
|
||
| {%if feedbackcount%} | ||
| <h2>Feedback</h2> | ||
| <h3>Feedback link</h3> |
There was a problem hiding this comment.
I wasn't sure if this should be conditional on if speaker feedback is open. We want the QR code to be available early enough so that speakers include it in their slide deck, so long before the conference starts
There was a problem hiding this comment.
I think it's reasonable to show the QR code as soon as the session is approved (but not for sessions that are not approved, such as pending or rejected of course).
But but instead we should remove the QR code maybe on the combination of "speaker feedback is closed but we are past the end date of the conference"?
There was a problem hiding this comment.
Why remove the QR-Code once it is there? What purpose does this serve to hide the code.
There was a problem hiding this comment.
I've updated the patch to hide the QR code if the session is approved or on the reserve list but otherwise hide it
There was a problem hiding this comment.
Sorry to not catch that in my first high level overview, but -- comparisons should be made on the status code, not the status string. In case we ever (unlikely, I know) get a translation. But also, that's the pattern that other comparison use.
I think we should also try to avoid generating the qrcode if it's not going to be used, as that's probably the more expensive of all the parts of generating the page. So maybe putting the filter in the code to only generate it when it's needed, and then conditional it on whether it was generated or not, could be a way forward from that that would solve both those at once?
| Attendees will be able to leave <a href="/events/{{conference.urlname}}/feedback/{{session.id}}">feedback</a> on your talk. | ||
| This link will work once your talk has started. You can include the below QR code in your slides to increase the response rate. | ||
| </p> | ||
| <p class="feedbak-qrcode"><img src="data:image/png;base64,{{ feedbackqrcode }}"></p> |
|
Also, feedback URLs should have trailing slashes, to avoid an extra round of redirect. |
* Fix typo is css name * Hide QR code for sessions that aren't on the approved or reserve status
|
I think your update caught one of the trailing slash ones, but not the other... |
* add trailing / to url
|
This has been merged. |
|
Thanks! |
3 participants
This makes it easy for speakers to include the feedback QR code in their slides
Fixes #188