Skip to content

secret key rotation: fix key list ordering #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pgjones merged 1 commit into from
Aug 2, 2025
Merged

secret key rotation: fix key list ordering #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
0.11.1 (Unreleased)
-------------------

* Flask backport: Fix signing key selection order when key rotation is enabled
via ``SECRET_KEY_FALLBACKS``.
<https://github.com/pallets/flask/security/advisories/GHSA-4grg-w6v8-c28g>

0.11.0 2024-12-26
-----------------

Expand Down
4 changes: 3 additions & 1 deletion src/quart_auth/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,13 @@ def load_token(self, token: str, app: Optional[Quart] = None) -> Optional[str]:
if app is None:
app = current_app

keys = [app.secret_key]
keys = []

if fallbacks := app.config.get("SECRET_KEY_FALLBACKS"):
keys.extend(fallbacks)

keys.append(app.secret_key) # itsdangerous expects current key at top

serializer = self.serializer_class(keys, self.salt) # type: ignore[arg-type]
try:
return serializer.loads(token, max_age=self.duration)
Expand Down