Skip to content

Translate push validation error title - #4656

Merged
pglombardo merged 1 commit into
masterfrom
fix/translate-push-error-title
Jul 20, 2026
Merged

Translate push validation error title#4656
pglombardo merged 1 commit into
masterfrom
fix/translate-push-error-title

Conversation

@pglombardo

@pglombardo pglombardo commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • Wraps the push validation error title in gettext n_() so the full sentence can be translated (including plural forms)
  • Fixes [Bug]: Error title is not translated correctly聽#4447 where French (and other locales) showed an untranslated "1 error prohibited this push from being saved:" while the error details were already translated

Fixes #4447

Test plan

  • Visit /p/new?tab=url&locale=fr and submit an invalid URL
  • Confirm the validation detail message still appears
  • After translation sync, confirm the error title translates (English remains: "1 error prohibited this push from being saved:")
  • bin/ci passes

@pglombardo
pglombardo merged commit a0562a3 into master Jul 20, 2026
2 checks passed
@pglombardo
pglombardo deleted the fix/translate-push-error-title branch July 20, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error title is not translated correctly

1 participant