Skip to content

Conversation

@mindsur
Copy link

@mindsur mindsur commented Jun 26, 2024

We are still heavily using nfdump files with older format.
So I have attempted to implement parsing of DataBlock type 2 and CommonRecord types based on the original C code.
I am quite new to GO and complete newbie in C so this might not be most accurate implementation.

Next, I still want to be able to process multiple files like it's done in original C code with "-M" and some way to aggregate flows with "-a".
Also, planning to do some optimizations with printing. Current Sprintf sample is quite slow converting between data types.

@mindsur
Copy link
Author

mindsur commented Jun 26, 2024

I've also implemented only small subset of extensions, primarily the ones that we use

@phaag
Copy link
Owner

phaag commented Jul 2, 2024

HI,
Many thanks for your code and your contribution. Anything which improves code and functionality is welcome. However, in the end the code must fit into the idea of the project.
I am a bit reluctant to introduce old compatibility in new projects. To convert old 1.6.x files into 1.7.x files is implemented in nfdump by simply read/write those files. Therefore I would be interested, if this would be an option for you, to convert those files into the newer format with nfdump and then read and process them with go-nfdump. It has the advantage that they are fully converted, not just those fields, you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants