-
Notifications
You must be signed in to change notification settings - Fork 468
Updates for PHP 8.4 compatibility #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ied as nullable is deprecated, the explicit nullable type must be used instead"
…d, the explicit nullable type must be used instead" errors.
…|int is deprecated" error.
|
Thanks, I applied this patch and arcanist is working again. I also had to turn off deprecation warnings to be able to parse the JSON output. diff --git a/bin/arc b/bin/arc
index 51528ca0..696f8191 100755
--- a/bin/arc
+++ b/bin/arc
@@ -1,5 +1,6 @@
#!/usr/bin/env php
<?php
+error_reporting(E_ALL ^ E_DEPRECATED);
if (function_exists('pcntl_async_signals')) {
pcntl_async_signals(true); |
|
Please can somebody merge this to master. |
2 similar comments
|
Please can somebody merge this to master. |
|
Please can somebody merge this to master. |
|
@semsudin @dushaoshuai @ez4bk |
|
Lol, I downgraded php as a short term mitigation. 8.4 is officially broken in this repo. 8.3 is still supported... for now. |
FutureProxy::__construct(): Implicitly marking parameter $proxied as nullable is deprecated, the explicit nullable type must be used instead.Implicitly marking parameter $proxied as nullable is deprecated, the explicit nullable type must be used instead.Passing null to parameter #1 ($status) of type string|int is deprecated.