Skip to content

Fix: PUT documentation #16707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Fix: PUT documentation #16707

merged 2 commits into from
Mar 3, 2025

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 1, 2025

  • Type: documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

There is no $_PUT superglobal in PHP.

Carry phalcon/ide-stubs#108

@glensc glensc force-pushed the patch-1 branch 2 times, most recently from 67a8df2 to b7a9026 Compare March 1, 2025 12:26
@glensc glensc marked this pull request as ready for review March 1, 2025 12:26
@niden niden changed the base branch from master to 5.0.x March 3, 2025 14:26
glensc and others added 2 commits March 3, 2025 08:34
There is no $_PUT superglobal in PHP
@niden niden merged commit 87b1cd4 into phalcon:5.0.x Mar 3, 2025
28 of 43 checks passed
@niden
Copy link
Member

niden commented Mar 3, 2025

Thank you @glensc

I had to rebase the branch to v5. We will fix the issue in the stubs repo after the next release.

@glensc
Copy link
Contributor Author

glensc commented Mar 3, 2025

Some unrelated composer.lock changes have slipped in.

@niden
Copy link
Member

niden commented Mar 3, 2025

Some unrelated composer.lock changes have slipped in.

That is fine. There were conflicts when I rebased your branch so I had to resolve that and then run composer update again so as to ensure the lock file was correct.

@glensc glensc deleted the patch-1 branch March 4, 2025 06:46
@glensc
Copy link
Contributor Author

glensc commented Mar 4, 2025

Ever thought of using dependabot or renovate bot to automate dependency updates? You can make them both group the updates and configure the interval, if you worry about pull request noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants