Add null attribute check in cloneResultMap method

[mpadinhabrandao]

Hello!

• Type: bug fix
• Link to issue: #16736

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Small description of change:

when type model and use this on leftjoin I have error when the leftjoin line doesn't exists because try assign null in variable that aren't null

Thanks

[raicabogdan]

@mpadinhabrandao Need to create an issue first explaining the issue you have, link that issue into your pull request and also update the change log. The target needs changed to 5.0.x, the master target is only for releases.

[niden]

@mpadinhabrandao could you please add a test for this?

[mpadinhabrandao]

@raicabogdan, I will create the issue later and update the description and the changelog.
@niden, After I create the issue I will try to make the test. Do you have any example?

@raicabogdan and @niden about the code, what is your opinion?

[raicabogdan]

Can work I think, theoretically it just skips assignment on null and leaves the model as is. Its why I haven't exactly said no to your suggestion fix on discord. Its just that the cloneResult works in other places as well and as such I'm not sure if it will break anything. @niden may have other insights... but he may not be aware of the underlying discussion, thus an issue explaining the problem is recommended.

Le. Looks like it's breaking tests

[mpadinhabrandao]

@raicabogdan and @niden, I have already written some tests and fixed the errors identified on the first try.
Who can repeat the actions?

[mpadinhabrandao]

I already fixed the phpcs and tomorrow I am going to review the integration errors

[mpadinhabrandao]

I already test with own product and solution works.
could you run the actition?

[mpadinhabrandao]

@niden, @raicabogdan , can someone start the tests?

[raicabogdan]

Sorry, but its not my decision, only @niden or @Jeckerson can do that.

[niden]

Thank you @mpadinhabrandao

[rudiservo]

Squashing commits would be nice, rest seems ok and valid.