Skip to content

CP-17510 image cursor - #17513

Merged
niden merged 6 commits into
5.0.xfrom
CP-17510-image-cursor
Aug 19, 2026
Merged

CP-17510 image cursor#17513
niden merged 6 commits into
5.0.xfrom
CP-17510-image-cursor

Conversation

@niden

@niden niden commented Aug 19, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Image\Adapter\Imagick::processReflection() applying the reflection to the first frame only of a multi-frame image, because the first two loops changed the reflection clone but moved the frame cursor of this->image

Fixed Phalcon\Image\Adapter\Imagick::background(), reflection(), text() and watermark() discarding any opacity below 100, and sharpen() rounding its amount down, because the division by 100 was stored back in the integer parameter; watermark() left the image unchanged for every opacity except 100

Fixed Phalcon\Image\Adapter\Imagick never coalescing the frames of a GIF, because the constructor compared getImageType(), an Imagick IMGTYPE_* value, against IMAGETYPE_GIF; the width and the height of an animated GIF now describe the canvas instead of whichever sub frame the cursor was on

Fixed Phalcon\Image\Adapter\Imagick::render() returning the current frame alone for a GIF, and save() failing with no encode delegate for this image format after an operation that rebuilds the image; both now mark every frame with the format, which setImageFormat() applies to the current frame only

Thanks

@niden
niden requested a review from Jeckerson August 19, 2026 03:54
@niden niden self-assigned this Aug 19, 2026
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Aug 19, 2026
Assisted-by: Claude Code
@niden niden added this to Phalcon v5 Aug 19, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in Phalcon v5 Aug 19, 2026
@niden niden moved this from Backlog to In Progress in Phalcon v5 Aug 19, 2026
@niden
niden merged commit 46e6386 into 5.0.x Aug 19, 2026
2 checks passed
@niden
niden deleted the CP-17510-image-cursor branch August 19, 2026 15:39
@github-project-automation github-project-automation Bot moved this from In Progress to Implemented in Phalcon v5 Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Projects

Status: Implemented

Development

Successfully merging this pull request may close these issues.

1 participant