CP-17510 image cursor - #17513
Merged
Merged
Conversation
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Image\Adapter\Imagick::processReflection()advances the wrong frame cursor #17510In raising this pull request, I confirm the following:
Fixed
Phalcon\Image\Adapter\Imagick::processReflection()applying the reflection to the first frame only of a multi-frame image, because the first two loops changed thereflectionclone but moved the frame cursor ofthis->imageFixed
Phalcon\Image\Adapter\Imagick::background(),reflection(),text()andwatermark()discarding any opacity below 100, andsharpen()rounding its amount down, because the division by 100 was stored back in the integer parameter;watermark()left the image unchanged for every opacity except 100Fixed
Phalcon\Image\Adapter\Imagicknever coalescing the frames of a GIF, because the constructor comparedgetImageType(), an ImagickIMGTYPE_*value, againstIMAGETYPE_GIF; the width and the height of an animated GIF now describe the canvas instead of whichever sub frame the cursor was onFixed
Phalcon\Image\Adapter\Imagick::render()returning the current frame alone for a GIF, andsave()failing withno encode delegate for this image formatafter an operation that rebuilds the image; both now mark every frame with the format, whichsetImageFormat()applies to the current frame onlyThanks