change BLQ call to nca_setup.R & perform calculations#1062
Draft
change BLQ call to nca_setup.R & perform calculations#1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1057
Description
This pull request introduces several improvements and bug fixes to the PKNCA data processing pipeline, focusing on better handling of BLQ (Below Limit of Quantification) imputation, exclusion logic, and interval formatting. The changes enhance robustness and maintainability, especially regarding global environment side effects and parameter imputation rules.
PKNCA_calculate_ncato avoid unintended side effects by only assigning the BLQ method globally if it is not already defined, and cleaning up after execution only if necessary.nca_setup_serverto keep the globalPKNCA_impute_method_blqin sync with the user's BLQ setting, ensuring consistent behavior across both NCA calculations and slope selector operations.rm_impute_obs_paramsto ensure half-life category parameters retain imputation, while other parameters are properly filtered, improving scientific validity and preventing incorrect exclusions.format_pkncadata_intervalsand related code to improve readability and maintainability, including formatting theselectstatement and fixing function signatures for clarity and consistency.Definition of Done
How to test
How to test features not covered by unit tests.
Contributor checklist
Notes to reviewer
Anything that the reviewer should know before tacking the pull request?