UI: Consolidate parameter-related settings into Parameter Selection tab#1239
Open
UI: Consolidate parameter-related settings into Parameter Selection tab#1239
Conversation
Move the Partial Interval Calculations UI into a standalone function so it can be rendered in the Parameter Selection tab. Server logic remains in settings_server unchanged. Closes #1238 Co-authored-by: Ona <no-reply@ona.com>
parameter_selection_ui now accepts units_ui, intervals_ui, and ratios_ui arguments. These are rendered as: - Units button: in the header row next to PK parameter details - Intervals: collapsible accordion below the matrix - Ratios: collapsible accordion below intervals - Detected Study Types: remains at the bottom Help dropdown updated to describe all sections. Co-authored-by: Ona <no-reply@ona.com>
- Rename 'Settings' tab to 'General Settings' - Move Units button, Partial Intervals, and Ratio Calculations into the Parameter Selection tab via parameter_selection_ui args - Remove Ratio Calculations accordion from General Settings - General Settings now contains: General Settings, Data Imputation, Flag Rule Sets, and Download settings button Co-authored-by: Ona <no-reply@ona.com>
Remove stale 'Parameter Selection' reference from the accordion open list — that panel no longer exists in settings_ui. Co-authored-by: Ona <no-reply@ona.com>
js3110
approved these changes
Apr 21, 2026
Collaborator
js3110
left a comment
There was a problem hiding this comment.
Great idea! makes much more sense, and looks good and works well :D
Reflect the new tab layout: - 'Setup > Parameter Selection' → 'Parameter Selection > Matrix' - 'Additional Analysis > Ratios' → 'Parameter Selection > Ratio Calculations' Co-authored-by: Ona <no-reply@ona.com>
…ps://github.com/pharmaverse/aNCA into 1238-enhancement/consolidate-parameter-settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1238
Description
Moves all parameter-related configuration into the Parameter Selection tab so users don't need to switch tabs to configure what gets calculated:
The Settings tab is renamed to General Settings and now only contains: General Settings, Data Imputation, Flag Rule Sets, and the Download settings button.
All accordion sections in Parameter Selection are collapsed by default to keep the page clean.
How to test
Contributor checklist
Notes to reviewer
No server logic was changed. All changes are UI reorganization:
settings.Rpartial_intervals_ui()as standalone function. Removed the accordion panel fromsettings_ui(). Fixed stale accordionopenparameter.parameter_selection.Runits_ui,intervals_ui,ratios_uiparameters. Renders them in the header row and as accordion panels. Updated help dropdown.nca_setup.Rparameter_selection_ui()via args. Removed ratios/units from Settings tab.Server wiring is preserved because all UI elements keep their original namespace IDs (e.g.,
partial_intervals_ui(ns(\"nca_settings\"))matchessettings_server(\"nca_settings\", ...))."