Closes #2652 derive_vars_joined_summary: Implement derive_vars_joined_summary()#2720
Closes #2652 derive_vars_joined_summary: Implement derive_vars_joined_summary()#2720
Conversation
|
|
pharmaverse/admiraldev#491 needs to be merged to fix the failing man check. |
manciniedoardo
left a comment
manciniedoardo
left a comment
There was a problem hiding this comment.
@bundfussr This looks great! I've tested the examples and given feedback, however I have not done a tech review.
manciniedoardo
left a comment
manciniedoardo
left a comment
There was a problem hiding this comment.
@bundfussr looks good to me, just suggested a typo fix. awaiting a tech review before merging.
|
@manciniedoardo , I have added examples for |
There was a problem hiding this comment.
One minor comment @bundfussr - looks great otherwise!
@rossfarrugia FYI - you may wish to reference the simple examples for |
I'd guess it will already get linked in the "See also" section so i personally wouldn't add more links, as i already have examples covering these arguments. I think users will get dizzy if we have them too often having to flick from page to page within the same package. I sometimes feel like that with Wikipedia where it's easy to find yourself in a hole and you forget where you started 😆 |
Makes sense! |
|
@bundfussr Not sure what happened with the templates - they passed in the other PR I added
|
| order = exprs(EXSTDTM), | ||
| filter_add = (EXDOSE > 0 | (EXDOSE == 0 & grepl("PLACEBO", EXTRT))) & !is.na(EXSTDTM), | ||
| filter_join = EXSTDTM <= ASTDTM & (ASTDTM <= EXENDTM | is.na(EXENDTM)), | ||
| mode = "first" |
There was a problem hiding this comment.
Hi @rossfarrugia , I slightly modified your DOSEON example such that it fails if multiple exposure records are found for an AE. I think in this case we shouldn't just take the first one but the programmer should take the decision how to handle it.
Do you agree?
There was a problem hiding this comment.
yes fine by me, i was thinking of similar at first as the spec for this one wasn't really clear but then i instead went with making it more likely to always run ok. would you add a note on this to the vignette above the code extract just to explain this? i think it would be useful for users to consider.
There was a problem hiding this comment.
would you add a note on this to the vignette above the code extract just to explain this? i think it would be useful for users to consider.
Good idea. Note added.
I think in the last release we introduced a minor "bug". By mistake, all variables of |
|
Yay!! new function - so I fixed some merge conflicts but then the man check failed. we should discuss as next meeting as i guess i did something wrong!?!?! |
It looks like you just forgot to update |
4 participants
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptxand re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.mdfor tracking developer-facing issues.pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()