Conversation
- Synced latest admiraldev programming strategy - Updated unit testing guidance - Auto-generated on 2026-02-18 15:43:07 UTC [skip ci]
…armaverse/admiral into 2920-add-copilot-instructions
- Synced latest admiraldev programming strategy - Updated unit testing guidance - Auto-generated on 2026-02-18 16:24:26 UTC [skip ci]
- Synced latest admiraldev programming strategy - Updated unit testing guidance - Auto-generated on 2026-02-18 16:44:44 UTC [skip ci]
- Synced latest admiraldev programming strategy - Updated unit testing guidance - Refreshed AGENT.md files for universal AI support - Auto-generated on 2026-02-18 18:26:30 UTC [skip ci]
bms63
left a comment
There was a problem hiding this comment.
Wondering if we could have a demo of this and more discussion at next deep-dive meeting?
- Synced latest admiraldev programming strategy - Updated unit testing guidance - Refreshed AGENT.md files for universal AI support - Auto-generated on 2026-02-18 18:44:07 UTC [skip ci]
- Synced latest admiraldev programming strategy - Updated unit testing guidance - Refreshed AGENT.md files for universal AI support - Auto-generated on 2026-02-18 18:57:31 UTC [skip ci]
- Synced latest admiraldev programming strategy - Updated unit testing guidance - Refreshed AGENT.md files for universal AI support - Auto-generated on 2026-02-18 19:48:42 UTC [skip ci]
- Synced latest admiraldev programming strategy - Updated unit testing guidance - Refreshed AGENT.md files for universal AI support - Auto-generated on 2026-02-18 20:11:28 UTC [skip ci]
|
The idea is that a GitHub action will periodically run a script that copies information from |
…armaverse/admiral into 2920-add-copilot-instructions
- Synced latest admiraldev programming strategy - Updated unit testing guidance - Refreshed AGENT.md files for universal AI support - Auto-generated on 2026-02-23 19:17:54 UTC [skip ci]
|
Will move this to |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "**Auto-generated:** See commit history for last update date", | ||
| "**Source:** admiraldev package vignettes", | ||
| "**Update script:** `source('.github/scripts/sync_admiraldev_copilot.R')`", | ||
| "", | ||
| "## Purpose", |
There was a problem hiding this comment.
The script correctly generates "See commit history for last update date" (lines 186, 277, 349), but the actual output files (AGENTS.md, tests/testthat/AGENTS.md, .github/copilot-instructions.md) contain hardcoded timestamps "2026-02-23 19:17:54". This indicates these files were not generated by running this script. The files should be regenerated using this script to ensure consistency.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptxand re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.mdfor tracking developer-facing issues.pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()