Draft: Closes #2952 tte: add end_dates and event_type argument to derive_param_tte() [create website]#2988
Conversation
bundfussr
changed the title
bundfussr
changed the title
|
|
The website/documentation is availables at https://pharmaverse.github.io/admiral/2952_tte. |
| #' ) | ||
| #' ) | ||
| #' | ||
| #' worsening <- event_source( |
There was a problem hiding this comment.
should we add a comment here noting the use of event_source() rather than censor_source()?
There was a problem hiding this comment.
I'm not sure. Isn't it clear from using event_source() that an event is defined here?
There was a problem hiding this comment.
i think it could be handy to have a small comment to user saying this source has changed.
There was a problem hiding this comment.
What do you mean by "this source has changed"?
There was a problem hiding this comment.
like it went from event_source to censor_source. just wondering if we should highlight to user or if my dusty old eyes just didn't notice until i did another read through :)
There was a problem hiding this comment.
Could you make a suggestion?
| #' dataset_name = "adsl", | ||
| #' date = TRTSDT, | ||
| #' censor = 3, | ||
| #' consider_end_dates = FALSE, |
There was a problem hiding this comment.
ooohhh a new argument for the programming strategy!?!
There was a problem hiding this comment.
I think it is unlikely that we will use it somewhere else. Thus I wouldn't add it to the programming strategy.
2 participants
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptxand re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.mdfor tracking developer-facing issues.pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()To create the website for the content of this PR add "[create website]" to the title of the pull request.