Skip to content

Close #123 release 02#124

Merged
jwang-lilly merged 3 commits intomainfrom
123_release_02
Feb 11, 2026
Merged

Close #123 release 02#124
jwang-lilly merged 3 commits intomainfrom
123_release_02

Conversation

@jwang-lilly
Copy link
Copy Markdown
Collaborator

@jwang-lilly jwang-lilly commented Feb 5, 2026

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral<ext> (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@jwang-lilly jwang-lilly linked an issue Feb 5, 2026 that may be closed by this pull request
@jwang-lilly jwang-lilly requested a review from Copilot February 5, 2026 18:54
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2026

Code Coverage

Package Line Rate Health
admiralneuro 100%
Summary 100% (64 / 64)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request prepares the admiralneuro package for its second CRAN release (version 0.2.1). The changes update package metadata and dependencies to reflect the new release status.

Changes:

  • Updated version number from 0.1.0.9014 to 0.2.1
  • Updated minimum dependency versions for admiral, admiraldev, and dplyr
  • Added bug reporting URL to package documentation

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
DESCRIPTION Updated package version to 0.2.1, added BugReports URL, and updated minimum versions for admiral, admiraldev, and dplyr dependencies
NEWS.md Removed "(development version)" suffix from header to indicate release status
cran-comments.md Updated release description from "first release" to "2nd release"
man/admiralneuro-package.Rd Added bug reporting URL to package documentation
.Rbuildignore Added doc directory to build ignore list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@Fanny-Gautier Fanny-Gautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version number to implement in NEWS.md (and to correct in DESCRIPTION?).

Comment thread DESCRIPTION
Package: admiralneuro
Title: Neuroscience Extension Package for ADaM in 'R' Asset Library
Version: 0.1.0.9014
Version: 0.2.1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it 0.2.1 while first release was 0.1.0? I believe it should be 0.2.0.

Copy link
Copy Markdown
Collaborator Author

@jwang-lilly jwang-lilly Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fanny-Gautier, I sent out 0.2.0 first but forgot to remove (development version) from the NEWS.md. It was too late to edit as admiralneuro hit CRAN right away, within an hour of submission. Therefore, I had to bump up to 0.2.1.

Comment thread NEWS.md Outdated
@Fanny-Gautier
Copy link
Copy Markdown
Contributor

Hi @jwang-lilly ,
Could you please clarify the status of {admiralneuro}? It appears to be available on CRAN as version 0.2.1 since 2026‑02‑04, but the website is still showing the older version 0.1.0 because the PR has not yet been merged into the main branch.
image
image

Could you also confirm which version number will be (or is currently) used so that I can correctly reference it in the {pharmaverseadam} package for the addition of {admiralneuro} data?

Thank you.

@Fanny-Gautier
Copy link
Copy Markdown
Contributor

The title of the PR should start with [skip vbump]; otherwise, the version number will continue incrementing when the PR is merged into main.

Also, to avoid last‑minute errors, it is preferable to have the package reviewed and approved before submitting it to CRAN. The merge should be done only after you receive the email confirming that it is on its way to CRAN.

Co-authored-by: Fanny Gautier <157114584+Fanny-Gautier@users.noreply.github.com>
@jwang-lilly jwang-lilly merged commit 6f98276 into main Feb 11, 2026
16 checks passed
@jwang-lilly jwang-lilly deleted the 123_release_02 branch February 11, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.2.1 Release

3 participants