Open
Conversation
meilinjiang
assigned
meilinjiang,
jwang-lilly and
Fanny-Gautier and unassigned
meilinjiang
|
jwang-lilly
approved these changes
Apr 1, 2026
Collaborator
|
@meilinjiang, all look great! You may need to rerun the styler, commit and push again. Oh, check off all the boxes. |
Fanny-Gautier
requested changes
Apr 1, 2026
Contributor
Fanny-Gautier
left a comment
Fanny-Gautier
left a comment
There was a problem hiding this comment.
Please implement below comments, run styler() and update NEWS.md accordingly.
| # https://pharmaverse.github.io/admiral/articles/admiral.html#handling-of-missing-values # nolint | ||
| adlb <- convert_blanks_to_na(lb_neuro) | ||
| adsl <- convert_blanks_to_na(admiralneuro_adsl) | ||
|
|
Contributor
There was a problem hiding this comment.
Please delete extra spaces
| ) | ||
|
|
||
| ## Domain-specific derivations ---- | ||
|
|
Contributor
There was a problem hiding this comment.
Please delete extra spaces
|
|
||
| # Final Steps, Select final variables and Add labels ---- | ||
| # This process will be based on your metadata, no example given for this reason | ||
|
|
Contributor
There was a problem hiding this comment.
Please delete extra spaces
|
|
||
| adlb <- adlb %>% | ||
| ## Add PARAMCD and PARAM ---- | ||
| derive_vars_merged_lookup( |
| # Use e.g. `haven::read_sas()` to read in .sas7bdat, or other suitable functions | ||
| # as needed and assign to the variables below. | ||
| # For illustration purposes read in pharmaversesdtm and admiralneuro neuro test data | ||
| # nv <- pharmaversesdtm::nv_neuro |
Contributor
There was a problem hiding this comment.
Please delete unnecessary code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesdevtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral<ext> (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()