Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a new ADER (Exposure Response Data) template to the admiralonco package. The template is designed to create analysis datasets for exposure-response modeling by combining time-to-event data, response data, and various baseline covariates including demographics, vital signs, and laboratory values.
Changes:
- Added inst/templates/ad_ader.R template for creating ADER datasets with exposure-response variables, covariates, and baseline measurements
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
inst/templates/ad_ader.R
Outdated
| data("admiral_adsl") | ||
| data("admiral_adrs") |
There was a problem hiding this comment.
The template uses data("admiral_adsl") and data("admiral_adrs") which is inconsistent with other templates in this package that use data("adsl") and data("adrs_onco") respectively. This inconsistency may cause issues if these dataset names don't exist in the expected packages. Review other templates (e.g., inst/templates/ad_adtte.R line 20, inst/templates/ad_adrs.R line 22) for the correct dataset names to ensure consistency.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| adsl <- admiral_adsl | ||
| adrs <- admiral_adrs | ||
|
|
||
| adtte <- pharmaverseadam::adtte_onco |
There was a problem hiding this comment.
@bundfussr and @manciniedoardo If I want to include adtte_onco as source, should it also be saved in {admiralonco}? Currently it is pulled from {pharmaverseadam}
There was a problem hiding this comment.
Pulling from pharmaverseadam would introduce a circular dependency because pharmaverseadam itself has a dependency on admiralonco. So I would say yes.
There was a problem hiding this comment.
I'm not sure. In the other templates we use the ADaM datasets from pharmaverseadam. Even in the vignettes we use them. So it shouldn't cause technical issues.
The only tricky scenario I'm aware of is when for example adrs_onco changes. In this case we would need to release admiralonco with the updated ADRS template, then release pharmaverseadam with the updated adrs_onco dataset, and finally recreate the admiralonco website to use the updated adrs_onco dataset in the ADTTE vignette.
Maybe we should remove admiral_adrs from admiralonco it seems that it isn't used anywhere.
There was a problem hiding this comment.
ok, if that works then it's fine - personally i'd rather not have all these steps but final call is yours of course!
There was a problem hiding this comment.
By the way, I think even in ad_adtte.R the data("adrs_onco") is pulling from {pharmaverseadam} rather than the local admiral_adrs object.
There was a problem hiding this comment.
Yes, I would use the datasets from pharmaverseadam. Whenever this causes issues in the future we can change it. But I think it's very unlikely.
bundfussr
left a comment
There was a problem hiding this comment.
@jeffreyad , could you create a vignette for these templates?
I think with a vignette it is easier for users to understand (and find) these templates.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.main.styler::style_file()to style R and Rmd filesdevtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdpkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()The following line requests to update the man pages by the "Man Pages" workflow.
/roxygenize