Closes #81 #92 #93 #94 #95 #96 #97 #99: Various updates#100
Closes #81 #92 #93 #94 #95 #96 #97 #99: Various updates#100manciniedoardo merged 16 commits intomainfrom
Conversation
Merge branch 'main' into 81_89_92_93_94_95_96_97_various_updates # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
@pharmaverse/admiral finally took some time to update admiraltemplate in line with the last year's updates - please take a look! |
bundfussr
left a comment
There was a problem hiding this comment.
Should we update .github/workflows/common.yml?
In .github/CODEOWNERS Dinakar is referenced. Should we change this?
yes, good idea to remove mention of @cicdguy.
Do you mean with your new workflows? |
Yes |
Co-authored-by: Stefan Bundfuss <[email protected]>
|
apologies @bms63 I somehow imagined you'd approved yesterday and thus i merged the PR, but now i saw you had not. if you have any other comments i'm happy to open another PR. |
Closes #81
Closes #92
Closes #93
Closes #94
Closes #95
Closes #96
Closes #97
Closes #99
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesdevtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral<ext> (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()