Skip to content

Closes #81 #92 #93 #94 #95 #96 #97 #99: Various updates#100

Merged
manciniedoardo merged 16 commits intomainfrom
81_89_92_93_94_95_96_97_various_updates
Feb 24, 2026
Merged

Closes #81 #92 #93 #94 #95 #96 #97 #99: Various updates#100
manciniedoardo merged 16 commits intomainfrom
81_89_92_93_94_95_96_97_various_updates

Conversation

@manciniedoardo
Copy link
Copy Markdown
Collaborator

@manciniedoardo manciniedoardo commented Feb 23, 2026

Closes #81
Closes #92
Closes #93
Closes #94
Closes #95
Closes #96
Closes #97
Closes #99

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral<ext> (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Merge branch 'main' into 81_89_92_93_94_95_96_97_various_updates
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@manciniedoardo
Copy link
Copy Markdown
Collaborator Author

@pharmaverse/admiral finally took some time to update admiraltemplate in line with the last year's updates - please take a look!

Copy link
Copy Markdown
Collaborator

@bundfussr bundfussr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update .github/workflows/common.yml?
In .github/CODEOWNERS Dinakar is referenced. Should we change this?

@manciniedoardo
Copy link
Copy Markdown
Collaborator Author

Should we update .github/workflows/common.yml? In .github/CODEOWNERS Dinakar is referenced. Should we change this?

yes, good idea to remove mention of @cicdguy.

Should we update .github/workflows/common.yml?

Do you mean with your new workflows?

@bundfussr
Copy link
Copy Markdown
Collaborator

Should we update .github/workflows/common.yml?

Do you mean with your new workflows?

Yes

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 23, 2026

Code Coverage

Package Line Rate Health
admiraltemplate 100%
Summary 100% (3 / 3)

@manciniedoardo manciniedoardo merged commit e23e0fb into main Feb 24, 2026
15 checks passed
@manciniedoardo manciniedoardo deleted the 81_89_92_93_94_95_96_97_various_updates branch February 24, 2026 09:25
@manciniedoardo
Copy link
Copy Markdown
Collaborator Author

apologies @bms63 I somehow imagined you'd approved yesterday and thus i merged the PR, but now i saw you had not. if you have any other comments i'm happy to open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants