Skip to content

Removed the --skipinstalled so it will force reinstalling packages even if they are already installed. This will install admiral 1.4.0 properly on upgrade.#15

Merged
bms63 merged 1 commit intopharmaverse:mainfrom
kimjj93:kimjj93/issue14
Feb 17, 2026
Merged

Removed the --skipinstalled so it will force reinstalling packages even if they are already installed. This will install admiral 1.4.0 properly on upgrade.#15
bms63 merged 1 commit intopharmaverse:mainfrom
kimjj93:kimjj93/issue14

Conversation

@kimjj93
Copy link
Copy Markdown
Contributor

@kimjj93 kimjj93 commented Jan 25, 2026

No description provided.

…en if they are already installed. This will install admiral 1.4.0 properly on upgrade.
@Polkas
Copy link
Copy Markdown
Collaborator

Polkas commented Feb 12, 2026

LGTM

We have to be aware that this change will have a greater impact on the base rocker image.
We will reinstall many of R packages already on the base rocker image.
In theory, we want to leave the base image as untouched as possible.

@kimjj93 why do you think this update is needed? Thanks

@Polkas Polkas self-requested a review February 12, 2026 08:47
@Polkas
Copy link
Copy Markdown
Collaborator

Polkas commented Feb 12, 2026

Additionally, @kimjj93 thank you for your support.

@bms63 bms63 merged commit 9214242 into pharmaverse:main Feb 17, 2026
2 checks passed
@kimjj93 kimjj93 deleted the kimjj93/issue14 branch February 17, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants