Closes #97 Add {whirl} to logging article#98
Merged
rossfarrugia merged 4 commits intopharmaverse:mainfrom May 7, 2025
Merged
Conversation
Contributor
Author
|
@bms63 tagging for the review :) |
bms63
reviewed
Apr 24, 2025
| logr, | ||
| logrx | ||
| logrx, | ||
| whirl |
Collaborator
There was a problem hiding this comment.
so excited to see this added!
bms63
reviewed
Apr 25, 2025
Collaborator
bms63
left a comment
There was a problem hiding this comment.
I am loving this read!! @rossfarrugia FYI
I need to generate the site locally to review, but my first pass gives it an A+
Contributor
|
thanks both - will take a look in the next week or 2 and try to coordinate this example publishing along with hopefully getting the package added to pharmaverse |
rossfarrugia
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
I have added whirl to the comparison article of the different logging packages (currently log and logrx).
In order to not change the article too much I have mostly added whirl in the existing sections, and then I added one extra section on how to execute multiple scripts with whirl.
Note that I am executing the log generation inside the Quarto document to make sure it always reflects the latest version of whirl. I see that is not the case for logr and logrx. I will be happy to update their examples to do the same, or change mine to also use a static log.
I have tested this by building webpage locally with all the latest package versions.
I was not able to link an issue, but have created #97 for his PR.
Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!
Closes #<insert_issue_number>at the beginning of your PR title. Use the Edit button in the top-right if you need to update.DESCRIPTIONfile.DESCRIPTIONfile'sImportssection.