Skip to content

Adding in patchwork:free functionality#257

Open
ShreyaSreeram27 wants to merge 5 commits intomainfrom
feature-request-theme-risktable-#230
Open

Adding in patchwork:free functionality#257
ShreyaSreeram27 wants to merge 5 commits intomainfrom
feature-request-theme-risktable-#230

Conversation

@ShreyaSreeram27
Copy link
Copy Markdown
Collaborator

@ShreyaSreeram27 ShreyaSreeram27 commented Aug 22, 2025

What changes are proposed in this pull request?

  • Adding in patchwork:free() to better align risktables with plots, especially when x-axes labels are very long.

If there is an GitHub issue associated with this pull request, please provide link.
Closes #230


Reviewer Checklist (if item does not apply, mark as complete)

  • Ensure all package dependencies are installed by running renv::install()
  • PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Overall code coverage remains >99.5%. Review coverage with withr::with_envvar(list(CI = TRUE), code = devtools::test_coverage()). Begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# ggsurvfit (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ShreyaSreeram27 ShreyaSreeram27 changed the title adding in patchwork:free functionality and defining new function that… Adding in patchwork:free functionality Aug 22, 2025
… maintaining backward compatibility; there was no change done to ggsurvift_align_plots , to ensure minimal user api changea
@ShreyaSreeram27
Copy link
Copy Markdown
Collaborator Author

  • ggsurvfit_align_plots: looks at the area left of the primary plot; then right of the plot
  • then measures after making grobs
  • goes to risktable plot , then requires both to be the same length
  • if we require that the right hand sides of both are exact same length; then use patchwork::free to align the left hand sides of the plot and risktable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: additional arguments for theme_risktable_default()

1 participant