Skip to content

Testing2.0#262

Closed
ShreyaSreeram27 wants to merge 4 commits intomainfrom
testing2.0
Closed

Testing2.0#262
ShreyaSreeram27 wants to merge 4 commits intomainfrom
testing2.0

Conversation

@ShreyaSreeram27
Copy link
Copy Markdown
Collaborator

What changes are proposed in this pull request?

  • Updating description file to bump down the ggplot2 ver number.
  • Including Shreya Sreeram as an author.
  • Committing the new snapshots.

If there is an GitHub issue associated with this pull request, please provide link.

Closes #258


Reviewer Checklist (if item does not apply, mark as complete)

  • Ensure all package dependencies are installed by running renv::install()
  • PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Overall code coverage remains >99.5%. Review coverage with withr::with_envvar(list(CI = TRUE), code = devtools::test_coverage()). Begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# ggsurvfit (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release ggsurvfit 1.2.0

2 participants