add_quantile() plateau bug fix#273
Merged
ddsjoberg merged 3 commits intopharmaverse:mainfrom Apr 7, 2026
Merged
Conversation
Contributor
Author
|
Hey there, @ddsjoberg! Wanted to bump this bug fix from 3 weeks ago in case it got buried - let me know if anything is needed on my end |
Collaborator
Thank you for the PR @KennethATaylor ! Nothing from your end at the moment. I just haven't had the bandwidth recently. Hope to get to it soon! |
ddsjoberg
approved these changes
Apr 7, 2026
Collaborator
ddsjoberg
left a comment
There was a problem hiding this comment.
Thank you for the PR! VERY much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got a little free time and fixed the bug I laid out in #270.
add_quantile()to fix the bug while ensuring no accidental breaking changes or unintentional issues with current test suiteNEWS.mdCloses #270
Reviewer Checklist (if item does not apply, mark as complete)
renv::install()_pkgdown.ymlpkgdown::build_site(). Check the R console for errors, and review the rendered website.withr::with_envvar(list(CI = TRUE), code = devtools::test_coverage()). Begin in a fresh R session without any packages loaded.usethis::use_spell_check()runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.mdwith the changes from this pull request under the heading "# ggsurvfit (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")usethis::use_spell_check()again