Skip to content

add_quantile() plateau bug fix#273

Merged
ddsjoberg merged 3 commits intopharmaverse:mainfrom
KennethATaylor:add_quantile_plateau_fix
Apr 7, 2026
Merged

add_quantile() plateau bug fix#273
ddsjoberg merged 3 commits intopharmaverse:mainfrom
KennethATaylor:add_quantile_plateau_fix

Conversation

@KennethATaylor
Copy link
Copy Markdown
Contributor

Got a little free time and fixed the bug I laid out in #270.

  • Made updates to add_quantile() to fix the bug while ensuring no accidental breaking changes or unintentional issues with current test suite
  • No new tests added since prior test suite already had some plots where plateaus were present. Snapshots were updated, but only the quantile annotations that were previously impacted by the bug were changed
  • Updated NEWS.md

Closes #270


Reviewer Checklist (if item does not apply, mark as complete)

  • Ensure all package dependencies are installed by running renv::install()
  • PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Overall code coverage remains >99.5%. Review coverage with withr::with_envvar(list(CI = TRUE), code = devtools::test_coverage()). Begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# ggsurvfit (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@KennethATaylor
Copy link
Copy Markdown
Contributor Author

Hey there, @ddsjoberg! Wanted to bump this bug fix from 3 weeks ago in case it got buried - let me know if anything is needed on my end

@ddsjoberg
Copy link
Copy Markdown
Collaborator

Hey there, @ddsjoberg! Wanted to bump this bug fix from 3 weeks ago in case it got buried - let me know if anything is needed on my end

Thank you for the PR @KennethATaylor ! Nothing from your end at the moment. I just haven't had the bandwidth recently. Hope to get to it soon!

Copy link
Copy Markdown
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! VERY much appreciated!

@ddsjoberg ddsjoberg merged commit 0b98640 into pharmaverse:main Apr 7, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: add_quantile() discrepancy compared to survival::quantile.survfit() when there is a plateau at the specified quantile

2 participants