Skip to content

Closes #107 : docs: ✏️ spellcheck(): change "Retrievel" to "Retrieval"#108

Merged
manciniedoardo merged 2 commits intopharmaverse:mainfrom
munoztd0:main
May 22, 2025
Merged

Closes #107 : docs: ✏️ spellcheck(): change "Retrievel" to "Retrieval"#108
manciniedoardo merged 2 commits intopharmaverse:mainfrom
munoztd0:main

Conversation

@munoztd0
Copy link
Copy Markdown
Contributor

@munoztd0 munoztd0 commented May 21, 2025

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes Documentation: Typo -> spellcheck(): change "Retrievel" to "Retrieval" #107 into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build pharmaverseadam site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new datasets occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link
Copy Markdown
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @munoztd0! Appreciate you flagging this and then implementing the fix.

One minor note that the upstream source for our labels is actually inst/extdata/adams-specs.xlsx - the JSON file is generated later as is described here. As such please could you make the change in the XLSX as well? Thanks.

@munoztd0
Copy link
Copy Markdown
Contributor Author

Of course the .xlsx binaries are not caught by the regex 🤦.
I made the change accordingly !
(PS: You send me a Roche-only access link so I could not check it out)

@manciniedoardo
Copy link
Copy Markdown
Collaborator

Of course the .xlsx binaries are not caught by the regex 🤦. I made the change accordingly ! (PS: You send me a Roche-only access link so I could not check it out)

Sorry! Had pasted the wrong link. Updated now.

@manciniedoardo manciniedoardo self-requested a review May 22, 2025 12:07
Copy link
Copy Markdown
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@manciniedoardo manciniedoardo merged commit 6bb6a4b into pharmaverse:main May 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: Typo -> spellcheck(): change "Retrievel" to "Retrieval"

2 participants