Skip to content

Closes #115 package maintainer update#117

Merged
Fanny-Gautier merged 7 commits intomainfrom
115_update_maintainer
Aug 13, 2025
Merged

Closes #115 package maintainer update#117
Fanny-Gautier merged 7 commits intomainfrom
115_update_maintainer

Conversation

@manciniedoardo
Copy link
Copy Markdown
Collaborator

@manciniedoardo manciniedoardo commented Aug 7, 2025

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build pharmaverseadam site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new datasets occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link
Copy Markdown
Collaborator

@Lina2689 Lina2689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update NEWS.md for these modifications.

@manciniedoardo manciniedoardo requested a review from Lina2689 August 7, 2025 12:12
Comment thread DESCRIPTION Outdated
Comment thread NEWS.md
## Documentation

- The package maintainer was updated from Edoardo Mancini to Fanny Gautier. (#186)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue number should be #115 instead of #186

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for spotting, was editing the sdtm package too and must've switched them by accident!

@Lina2689 Lina2689 linked an issue Aug 8, 2025 that may be closed by this pull request
4 tasks
@manciniedoardo manciniedoardo requested a review from Lina2689 August 8, 2025 07:07
Comment thread DESCRIPTION Outdated
Co-authored-by: Lina Patil <157117024+Lina2689@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@Fanny-Gautier Fanny-Gautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Comment thread DESCRIPTION Outdated
Comment thread README.md Outdated
@manciniedoardo
Copy link
Copy Markdown
Collaborator Author

manciniedoardo commented Aug 8, 2025

@Lina2689 @Fanny-Gautier thanks for the thorough reviews and sorry for the inconsistencies. Tried to do too much at once 🤦

Copy link
Copy Markdown
Collaborator

@Fanny-Gautier Fanny-Gautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good now! Thanks for the updates!

Copy link
Copy Markdown
Collaborator

@Lina2689 Lina2689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! It's good now.

@Fanny-Gautier Fanny-Gautier merged commit 631da4c into main Aug 13, 2025
16 checks passed
@Fanny-Gautier Fanny-Gautier deleted the 115_update_maintainer branch August 13, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DESCRIPTION file updates for Authors / Package maintainer

3 participants