Skip to content

Closes #113 Add copyright holder logos#119

Merged
Fanny-Gautier merged 4 commits intomainfrom
113_add_copyright_holder_logos
Aug 13, 2025
Merged

Closes #113 Add copyright holder logos#119
Fanny-Gautier merged 4 commits intomainfrom
113_add_copyright_holder_logos

Conversation

@Fanny-Gautier
Copy link
Copy Markdown
Collaborator

@Fanny-Gautier Fanny-Gautier commented Aug 8, 2025

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build pharmaverseadam site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new datasets occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@Fanny-Gautier Fanny-Gautier linked an issue Aug 8, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but looks good!

Comment thread DESCRIPTION
person("Lina", "Patil", email = "lina.patil@cytel.com", role = "aut"),
person("Vladyslav", "Shuliar", role = "aut",
comment = c(ORCID = "0009-0008-2354-8999"))
comment = c(ORCID = "0009-0008-2354-8999")),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again recommend merging other PRs first

Comment thread NEWS.md Outdated
Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
@Fanny-Gautier Fanny-Gautier changed the title Closes #113 Add copyright loder logos Closes #113 Add copyright holder logos Aug 12, 2025
@Fanny-Gautier Fanny-Gautier merged commit 51703b0 into main Aug 13, 2025
16 checks passed
@Fanny-Gautier Fanny-Gautier deleted the 113_add_copyright_holder_logos branch August 13, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add copyright holder logos in front-page side bar

3 participants